search

pkp / orcidProfile

A plugin to pull ORCID information into a PKP user profile
GNU General Public License v3.0
16 stars 50 forks source link

Connect button missing on register page #294

Closed juanCure closed 9 months ago

juanCure commented 10 months ago

Describe the bug I have installed a OJS v3.3.0.15 and upgraded the orcidProfile plugin to v1.1.3.10 and set up the plugin with the Sandbox Public API, and I have noticed that the Create or Connect your ORCID ID button is missing on the register a new user's account page. The doubt here is, this is either a expected feature or a bug?

To Reproduce Steps to reproduce the behavior:

  1. Install OJS v3.3.0.15
  2. Upgrade the orcidProfile module from plugin gallery
  3. Set up the orcidProfile module to use the Sandbox Public API
  4. Go to Register page 10 register_page

In another way, I have noticed this button appears in the Profile > Public page. 11 profile_page

The enviroment of the server is: OS: Centos 7 PHP v7.4.33 MySQL 8.0.23

asmecher commented 10 months ago

Cross-posted: https://forum.pkp.sfu.ca/t/ojs-3-3-0-11-orcid-button-missing/81273/5

ewhanson commented 10 months ago

@asmecher could you have a look? It was a quick fix to add it back in. Not an issue in stable-3_4_0. Thanks!

PR:

ewhanson commented 10 months ago

Thanks for the report @juanCure! Working on getting a fix for this in.

asmecher commented 9 months ago

@ewhanson, the PR link above is actually back to this same issue! Can you correct?

ewhanson commented 9 months ago

@ewhanson, the PR link above is actually back to this same issue! Can you correct?

Oops! Should be correct above now. Thanks!

asmecher commented 9 months ago

Merged, thanks! I'm guessing this needs forward-porting too, right?

ewhanson commented 9 months ago

Merged, thanks! I'm guessing this needs forward-porting too, right?

Thanks! Nope, it shouldn't. I double checked in stable_3_4_0 and main and the button was present. It seems like it was accidentally removed in stable_3_3_0 at some point.

asmecher commented 9 months ago

Perfect, thanks!

jnugent commented 9 months ago

Hi everyone, with the re-addition of the connect button on the register page we are seeing a strange google recaptcha error now, with some debugging printed into the console. This comes back from Google (this locale key is not in the OJS codebase I don't think)

##common.captcha.error.timeout-or-duplicate##
The form could not be submitted. You may have been logged out. Please reload the page and try again.

and then nothing happens. We get this in the browser JS console:

ORCID Logged In: false [register:177:25]

If this is indeed broken, the feature should probably come back out. Dulip mentioned that it doesn't do much anyway.

ewhanson commented 9 months ago

Hey @jnugent, it does seem like it was causing an issue. I've gone ahead and undone the change (PR: #303).

bozana commented 9 months ago

@jnugent, oh, great that you have reported it -- there was a user in the forum having problems with google re-captcha, when installing the new orcid version... But, how comes actually that this makes a problem? Any idea? Anyhow, yes, I also think we should then remove it...

jnugent commented 9 months ago

Hi @bozana I am not entirely sure, but could it be possible that when the ORCID modal window closes after authenticating, there is a form trigger that is submitting the google recaptcha on the registration form? Then it happens again when the form is actually submitted by the user?

Erik has already reversed his commit so the register via orcid feature is removed now.

bozana commented 9 months ago

Hi @jnugent, do you maybe also have an 3.4 installation together with re-captcha? The ORCID button is also in 3.4, I think...

SupremeDimeji commented 8 months ago

Hi @ewhanson @asmecher, Is there any solution to the missing Connect ID button? Or is it permanently removed now?

I'm having the same issue on ojs 3.3. orcid plugin v1_1_3-12 Thanks

ewhanson commented 8 months ago

Hi @SupremeDimeji, the Connect ID button has not permanently been removed, but there are a few issues that need to be addressed before we add the button back in. Thanks.