pkp / orcidProfile

A plugin to pull ORCID information into a PKP user profile
GNU General Public License v3.0
16 stars 50 forks source link

pkp/pkp-lib#9296 Sandbox settings #311

Closed touhidurabir closed 8 months ago

touhidurabir commented 8 months ago

for pkp/pkp-lib#9296

asmecher commented 8 months ago

@ewhanson, would you prefer that this was merged here, or that the functionality was separately ported into your work for main?

ewhanson commented 8 months ago

Hey @asmecher, probably easier for me to add directly as I've already removed pretty much all of the plugin code already. If you don't mind, I'll keep this PR open until I get it added then close it.

asmecher commented 8 months ago

That sounds fine to me, thanks. Would you like me to keep the issue it's attached to open, or will this be enough of a reminder?

ewhanson commented 8 months ago

Thanks @asmecher, this will be enough. I'll get it implemented today so shouldn't need too much of a reminder.

ewhanson commented 8 months ago

Added to WIP ORCID changes on main. Closing as complete.