search

pkp / ots

PKP XML Parsing Service
GNU General Public License v3.0
32 stars 19 forks source link

stop BIBTEXREFERENCES, CITATIONSTYLE and XMP modules from de-register… #112

Closed kaschioudi closed 6 years ago

kaschioudi commented 6 years ago

…ing documents from previous stages #109

axfelix commented 6 years ago

This looks good and is working, and I can request the missing stages from https://github.com/pkp/ots/issues/109! Thanks a bunch. One request before merging -- we should make the document names a little more explicit.

14__document.xml should be document_final.xml (so this is clearer to anyone looking at the job details page in OTS), and I'm not actually clear on what the different between 6html.zip and 8document.pdf is currently -- are they normally identical? If so, it'd be sufficient to make them html_final.zip and document_final.pdf.

axfelix commented 6 years ago

Oh, I just noticed, 14 isn't actually the final document.xml -- the final document.xml is still the one named document.xml (the one that's had the references merged). I should improve the documentation around our API here...

14__document.xml should probably be document_plain_citations.xml and document.xml should be document_final.xml in that case? And it seems like the different HTML zips are pre-reference styling and post-reference styling; I guess we should make 6__html.zip into html_plain_citations.zip and html_final.zip. And the PDFs differ because of the XMP? Hmmmm...

You know what, maybe this is fine after all. I'm going to merge.