search

pkp / ots

PKP XML Parsing Service
GNU General Public License v3.0
32 stars 19 forks source link

Empty contrib-group in conversionStage 5 #117

Open fabiobatalha opened 6 years ago

fabiobatalha commented 6 years ago

We are receiving a empty contrib-group in the conversionStage 5.

It is invalid against JATS and JATS4M

The job related to this issue is: 2651

It is enough to give the job number as reference?

In this same document the authors metadata were tagged as affiliations.

fabiobatalha commented 6 years ago

same problem in job: 2668, 2672

axfelix commented 6 years ago

OK, I can duplicate this, it's a very strange edge case. Basically, Cermine failed to find the authors and only populated contrib-group with aff tags, and we always move the aff tags out of contrib-group to make Texture happy. I've never seen another document that only finds aff but no actual authors, so I haven't implemented a check to make sure that contrib-group isn't empty after moving the aff tags out.

I guess I need to do that...

axfelix commented 6 years ago

@kaschioudi, I'm struggling to tell why this fix I just added isn't working, if you have the chance to take a look: https://github.com/pkp/ots/blob/master/module/MergeXMLOutputs/src/MergeXMLOutputs/Model/Converter/Merge.php#L231

kaschioudi commented 6 years ago

@axfelix do you still need me to look into this? Please me know.

axfelix commented 6 years ago

Yup, if you don't mind -- I was stumped and have put it down for now.