search

pkp / ots

PKP XML Parsing Service
GNU General Public License v3.0
32 stars 19 forks source link

fix #136 #137

Closed fabiobatalha closed 6 years ago

axfelix commented 6 years ago

Hi Fabio,

I'm honestly not sure I want to merge anything with the explicit purpose of supporting such an old version of PHP -- I'm planning to migrate us to supporting 7.x only by April 2019. Why do you need 5.4?

fabiobatalha commented 6 years ago

I'm using the default PHP distro version of CentOS 7.

I think this change is not a problem for PHP 7.X.

axfelix commented 6 years ago

OK, but we will be adding backwards incompatible changes without worrying about it beginning later this year. I'll merge this for now, but it should be a very temporary solution. CentOS 7's default PHP is ancient.

fabiobatalha commented 6 years ago

don't need to. I will upgrade the PHP to PHP 7.