pkp / ots

PKP XML Parsing Service
GNU General Public License v3.0
32 stars 19 forks source link

Validate Dar Article error, Revise your XML document in Substance Editor #144

Closed coastalplain closed 6 years ago

coastalplain commented 6 years ago

After creating a successful job on http://pkp-xml-demo.lib.sfu.ca that includes two test figures (artwork),

image

the "Revise your XML document in Substance Editor" (http://pkp-xml-demo.lib.sfu.ca/manager/editor/id/3793) fails on the Validate Dar Article.

image

I searched for validation errors with DarArticle, and am assuming that the high-level requirements for DarArticle validation is causing the issue. The error "<p> is not valid in <fig>" is a bit confusing because there is a <p>Lorem ipsum</p> located in the on DarArticle. Honestly I am currently way in over my head here and the problem may be quite simple.

axfelix commented 6 years ago

Hi,

Thanks for opening this issue! We're still producing a few minor validation issues against the current version of DarArticle (by generating weird edge-case JATS elements with some of our parsers), but I'm trying to eliminate these, so these reports help.

coastalplain commented 6 years ago

Deleting the figures and leaving the tables, we receive from this job:

ERROR:Internal Server Error

Deleting the table and leaving the figures gives the same error as without figures in first post:

image

However, after deleting the figures AND the table, it works wonderfully! Here is the job that worked completely and opened Substance Editor. Very nice!!

image

So my previous errors appear to definitely be related to the parsing of the Artwork/captions and the Table/caption.

axfelix commented 6 years ago

Thanks for investigating. I just pushed a temporary workaround if you want to try the original doc again...

coastalplain commented 6 years ago

Thank you! (I had to run one twice... Upload File Name is not visible since some time prior)

A single issue with both figures and table uploaded: image

With no figures (Job 3825 ... Nothing shows up in the editor window...

With no tables (Job 3824) ... Works great!

So, the figures appear to work and are incorporated, but the tables cause an error.

Thanks for all the help!