search

pkp / ots

PKP XML Parsing Service
GNU General Public License v3.0
32 stars 19 forks source link

Unit tests rely on sendmail #5

Closed crism closed 9 years ago

crism commented 9 years ago

The testRegisterActionValidUser() test attempts to use sendmail to send an actual e-mail to unittestuser2@example.com. This seems inappropriate, and also fails on a dev machine without sendmail installed.

crism commented 9 years ago

I think the right solution is to use setCallable() in Zend\Mail\Transport\Sendmail to use a testing stub instead.

axfelix commented 9 years ago

Any instance where "some bin that is hopefully on the path" is used in place of an actual PHP function is generally my fault, and changes are welcomed.

axfelix commented 9 years ago

Any activity on this?

crism commented 9 years ago

@axfelix—just turning my attention back to this now.