Recent Citation fixes seem to have broken Author name whitespace in HTML output

pkp / ots

PKP XML Parsing Service

GNU General Public License v3.0

32 stars 19 forks source link

Recent Citation fixes seem to have broken Author name whitespace in HTML output #59

Closed axfelix closed 8 years ago

axfelix commented 8 years ago

screenshot from 2016-02-15 12 52 18

axfelix commented 8 years ago

@kaschioudi Should be able to reproduce in this document -- note that the names are coming out with slightly broken spacing in the XML, and this leads to even more broken spacing in the HTML. This might involve two different fixes, pertaining to some of the stuff I tried to do (and screwed up) in https://github.com/pkp/xmlps/issues/60

eeg_comicsans.docx

<name><surname>Solomon</surname><given-names>GailE</given-names></name>

kaschioudi commented 8 years ago

@axfelix ; which version of the codebase was used? the HTML output seems fine using latest code on master branch.

eeg_html_output

axfelix commented 8 years ago

Huh! It's possible I fixed it in my last couple commits after all... but I reverted them on the live instance as I thought I'd broken bibtex output. Are you still getting .bib files as an available output format with that code?

kaschioudi commented 8 years ago

Yes, there is a document.bib file.

axfelix commented 8 years ago

Ha! I guess those commits worked after all. Thanks for testing, I'll fast forward the live instance back to head. Guess we can close this!

axfelix commented 8 years ago

This seems to still be an issue -- example in http://pkp-udev.lib.sfu.ca/manager/details/id/19284

axfelix commented 8 years ago

Closing again. Was a dependency issue on our demo site.