search

pkp / ots

PKP XML Parsing Service
GNU General Public License v3.0
32 stars 19 forks source link

<citation> elements in ref-list should actually be labeled <element-citation> #60

Closed axfelix closed 8 years ago

axfelix commented 8 years ago

Minor validation fix just noticed by development partner.

axfelix commented 8 years ago

Also, <ref rid> should've been <ref id>. Just fixed both of these in https://github.com/pkp/xmlps/commit/6340ed5f77b57f76e6286990eb83f68f300b4c62

axfelix commented 8 years ago

Changing that XSL is resulting in lots of and seeming to fail all documents with citations, with this in the logs:

2016/02/22 14:43:51 DEBUG Error loading the XSL style sheet

No idea how that's caused a breakage, it's such a small commit and there aren't any permissions issues, unless the stack had somehow cached the old XSLT for the in-progress jobs when I restarted the queues. Reverted to the prior commit for now.

axfelix commented 8 years ago

Oh, dammit, I forgot to change the closing tag of <element-citation>.

I really shouldn't multitask.

axfelix commented 8 years ago

Looks like the Pandoc merge is still broken.

axfelix commented 8 years ago

Reverted on the demo instance for now, will get back to this later. Thought I caught the other needed fixes but perhaps not: https://github.com/pkp/xmlps/commit/a9d49954614dc6a63ef5418ae098e84e7aa2c795

axfelix commented 8 years ago

@kaschioudi can you verify this is working on a checkout of master too? Hopefully it's all fixed now; I must have been confused when testing.

kaschioudi commented 8 years ago

from what I see, your fixes are working correctly :)

axfelix commented 8 years ago

Thanks! Sorry for the confusion here. Closing.