pkp / ots

PKP XML Parsing Service
GNU General Public License v3.0
32 stars 19 forks source link

Converter/ReferencesTest fails #7

Closed crism closed 9 years ago

crism commented 9 years ago
1) ReferencesConversionTest\Model\Converter\ReferencesTest::testConversion
Failed asserting that false is true.

/home/crism/src/xmlps/module/ReferencesConversion/test/ReferencesConversionTest/Model/Converter/ReferencesTest.php:58
crism commented 9 years ago

The line in question:

        $this->assertTrue(is_file($this->testOutputFile));

Which means something is going wrong up above:

        $this->references->setOutputFile($this->testOutputFile);
        $this->references->convert();
crism commented 9 years ago

ReferencesConversion\Model\Converter::convert() fails parsing the bibliography.

crism commented 9 years ago

ReferencesConversion\Model\Converter::parsCitExecute() has a hard-coded reference to vendor/MichaelThessel which is no longer valid.

crism commented 9 years ago

The knmnyn version of ParsCit has Perl module dependencies. Yay! More to document…

crism commented 9 years ago

RTFM, @crism. This is covered by the ParsCit requirements, as noted in our README.

crism commented 9 years ago

Got my local set-up working—had to do a tiny bit of C++ hacking to get CRF++ to build, but sorted!

axfelix commented 9 years ago

Glad! I think there's still a note submitted from me a few years ago on the Parscit project page FAQ about getting the crf libs working :)