search

pkp / pkp-github-actions

PKP Github Actions
0 stars 2 forks source link

Compatibility with PHPUnit 11+ #60

Closed touhidurabir closed 3 weeks ago

touhidurabir commented 1 month ago

The current php unit command PHPUNIT='php lib/pkp/lib/vendor/phpunit/phpunit/phpunit --configuration lib/pkp/tests/phpunit.xml --testdox --no-interaction' is not compatible with latest version of PHPUnit 11 as the option --on-interaction has been removed from Test Execution Options .

As the part of work https://github.com/pkp/pkp-lib/issues/9892 , we can and probably should upgrade the PHPUnit to version 11 which is failing to run the unit tests because of option --on-interaction with following error

PHPUnit 11.2.7 by Sebastian Bergmann and contributors.

Unknown option "--no-interaction"

PRs https://github.com/pkp/pkp-github-actions/pull/61 [MERGED] https://github.com/pkp/pkp-github-actions/pull/64

touhidurabir commented 1 month ago

@withanage can you please take a look at the linked PR at https://github.com/pkp/pkp-github-actions/issues/60#issue-2415576813 .

withanage commented 1 month ago

@touhidurabir sorry, for the delay! I reviewed the https://github.com/pkp/pkp-github-actions/pull/61 and approved it.

touhidurabir commented 1 month ago

@withanage can you take a look at the PR https://github.com/pkp/pkp-github-actions/pull/64 . I missed the use of -v flag with phpunit command which also removed for PHPUnit 11 .

asmecher commented 4 weeks ago

This can be closed now, right, @touhidurabir?

touhidurabir commented 4 weeks ago

It should be but lets keep it open until we merged the https://github.com/pkp/pkp-lib/issues/9892

touhidurabir commented 3 weeks ago

closing this as the issue https://github.com/pkp/pkp-lib/issues/9892 got merged