search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
297 stars 442 forks source link

New submission listing: assigned-to-me View should include authors? #10010

Open jardakotesovec opened 3 months ago

jardakotesovec commented 3 months ago

Describe the bug Not really a bug, but it might be worth adjusting.

If user has both author and editor roles - he can switch between 'Dashboards' for editors and 'My Submissions'. Screenshots are attached.

I would expect that if I am looking to editor dashboards - I would not see submission which is assigned to me as author?

What application are you using? OJS, OMP or OPS version main

Screenshot 2024-06-03 at 12 53 51 Screenshot 2024-06-03 at 12 53 46
Vitaliy-1 commented 3 months ago

Yeah, assigned submissions is one endpoint for editors and authors. Would it be ok to add an edition query parameter, isAuthor?

jardakotesovec commented 3 months ago

@Vitaliy-1 Based on the screenshot - I thought that these are two different views - Assigned to me (only editors gets that) and Active submissions (only authors gets that). Therefore I would expect that we would just need to tweak the Assigned to me view, so it does not include submissions where you are assigned as author and not editor?

Vitaliy-1 commented 3 months ago

For submissions list it's _submissions/assigned

Vitaliy-1 commented 3 months ago

On the second thought, I'll remove permissions to use _submissions/assigned for authors to avoid overburden with anonymising review data. Let's use submissions endpoint (PKPSubmissionController::getMany()). Also: https://github.com/pkp/pkp-lib/issues/10014