Closed temin closed 2 months ago
@asmecher I've created a PR for this. PRs
Description:
Emails with subject lines exceeding 255 characters will be truncated when saved to the database. An example of a truncated subject line would be Review accepted: Julie Janssen accepted review assignment for #31 Mwandenga — Exploring the Impact of Climate Variability on Photosynthetic Efficiency and Adaptive Mechanisms in Diverse Plant Species: Insights into Resilience and Sustainability in Ch...
An ellipsis is appended at the end to indicate truncation.
Thanks, @taslangraham, I've reviewed this: https://github.com/pkp/pkp-lib/pull/10100#pullrequestreview-2129112841
@asmecher I've made the requested changes and created a PR to forward port to main. PR - https://github.com/pkp/pkp-lib/pull/10104
Thanks, @taslangraham, I've merged both!
Describe the bug When an author submits a new article with a very long title (~170+ characters) or reviewer accepts a review of such article, the user interface hangs and the cogwheel just keeps on turning. User can continue only after page reload.
To Reproduce Steps to reproduce the behavior (author):
Steps to reproduce the behavior (reviewer):
Accept Review, Continue to Step #2
buttonWhat application are you using? OJS 3.4.0-5
Additional information In the background, article is submitted or review accepted. Emails are sent, but not saved in 'email_log' table. There is a PHP error logged:
The 'subject' column in 'email_logs' table is of type 'VARCHAR(255)'.
We fixed the problem by increasing the VARCHAR length in OJS database. Another 'no coding' workaround could be to change the email templates in 'ojs/lib/pkp/locale/en/emails.po':