search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
306 stars 445 forks source link

[OJS 3.4] you can add an empty keyword #10056

Closed forgive38 closed 4 months ago

forgive38 commented 4 months ago

Describe the bug Keywords are free text, but you can enter just a space character. I think OJS must check the content of a keyword

To Reproduce Go to a submission, keywords field: type a "space" and select it. You get an empty - more precisely only a space - keyword

What application are you using? OJS 3.4 testdrive / Firefox

Thank you

Hafsa-Naeem commented 4 months ago

Ready for review @asmecher PR OJS_main: pkp/pkp-lib##10056 Prevent dropdown from taking whitespace input in autosuggest

asmecher commented 4 months ago

Thanks, @Hafsa-Naeem -- passing to @jardakotesovec to review.

Hafsa-Naeem commented 4 months ago

@jardakotesovec Updated the PR#372 and it's ready for review again

jardakotesovec commented 4 months ago

Merged to main - @asmecher do you want to fix it for 3.4 as well? Just to note - 3.4 is using different components (from vue2 ecosystem)

asmecher commented 4 months ago

I think I'd be OK with leaving the fix for just main, if it's not a trivial backport.