search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
297 stars 442 forks source link

Submissions schema filters out declined&cancelled review assignments #10076

Open jardakotesovec opened 2 months ago

jardakotesovec commented 2 months ago

Describe the issue On new submission listing we would like to indicate for editors also review assignments that has been declined or cancelled. Currently Submissions Schema filters them out - https://github.com/pkp/pkp-lib/blob/main/classes/submission/maps/Schema.php#L422

The new submission listing is using the api/_submissions endpoint .

What application are you using? OJS, OMP or OPS version 3.5

Vitaliy-1 commented 2 months ago

Editors, Authors and Reviewers have access to the new dashboard. It might have sense to separate mapping of the submissions for editors from other roles, as it includes more data, for which authors and reviewers shouldn't have access to. Declined and cancelled reviews are such an example.

My proposal is to create a separate mapping for editor's list, e.g. Schema::mapToEditorsList()

ewhanson commented 2 months ago

I'm wondering if rather than a separate mapping, it would be possible to do this via some sort of permissions, e.g. an editor would have the extra review assignments included because they have permission to access them. That way we won't be maintaining multiple mappings that re similar but not exactly the same. I'll do some thinking on what that could look like and if that makes sense with the existing model we have in place.

Vitaliy-1 commented 1 week ago

it would be possible to do this via some sort of permissions

I'm currently working on adopting laravel permissions library but that's a long road