search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
299 stars 444 forks source link

OPS: Duplicate Galley Views Countes #10082

Closed bozana closed 3 months ago

bozana commented 3 months ago

s. https://forum.pkp.sfu.ca/t/duplicate-galley-view-counts/88363

When creating a new version of a preprint (and article) a new galley is created that points to/contains the same file ID as the previous galley. This function getTotalGalleyViews (s. https://github.com/pkp/ops/blob/stable-3_3_0/classes/submission/Submission.inc.php#L251) does not consider it however, which leads to wrong vies numbers.

PRs: stable-3_3_0: https://github.com/pkp/ops/pull/708 stable-3_4_0: https://github.com/pkp/ops/pull/709 main: https://github.com/pkp/ops/pull/710

bozana commented 3 months ago

@jonasraoni, could you please take a look at the PRs above? Thanks a lot!

bozana commented 3 months ago

Thanks a lot @jonasraoni!