search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
297 stars 441 forks source link

Accept Submission: Select Files -> Empty list of files #10102

Closed rmsoler closed 1 week ago

rmsoler commented 1 week ago

Describe the bug When a submission is accepted an empty file list appears in step3 "Select files"

To Reproduce Steps to reproduce the behavior:

  1. Accept submission
  2. Go to Step 3 "Select files"
  3. There are no files to select, the list of files is empty.

What application are you using? OJS 3.4

Additional information Please see the screenshot below for details. Ojs_Error_Screen5 Ojs_Error_Screen4 Ojs_Error_Screen3 Ojs_Error_Screen2 Ojs_Error_Screen1

asmecher commented 1 week ago

@rmsoler, the files that are available for selection in Step 3 of the Accept workflow are taken from the Revisions list, which is empty in at least one of your screenshots: image

If you want to pull forward additional files, you can always do that from the Copyediting workflow using the Upload/Select Files button: image Then, check the checkbox to gain access to files in all previous stages: image

Next time, the best place to start is the support forum (https://forum.pkp.sfu.ca/); then if an issue turns out to be a bug, we can open an entry here.

Long story short, I think this is intentional behaviour, though feel free to propose a change in the Feature Requests area of the forum if you have something specific in mind.

rmsoler commented 1 week ago

Thanks for the quick response, but I think this is a BUG because the Revisions list of the Round 1 is not empty as you can see in the screenshot.

In another screenshot you can see, in Round 2, that the file uploaded for review has been accepted, the status is "Accept Submission" state, so this file should be available because this file has ben accepted without changes by the revisor.

In the Step 1 and Step2, these files are available to include in the emails clicking on Attach Files, so why are they not available in the last step if they are the final files?

And finally, in the OJS 3.3 version, when a user accept a submissions, these files could be selected.

We will inform our client that this is the correct operation of OJS 3.4, but it is a operation that reduces capabilities with respect to OJS 3.3 and also does not seem appropriate for a good publication workflow.

Thank you.