search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
297 stars 441 forks source link

Reenable skipped tests for 3.5 #10115

Open jonasraoni opened 6 days ago

jonasraoni commented 6 days ago

Describe the bug At https://github.com/pkp/pkp-lib/issues/10061, a couple of tests have been disabled on the main branch for all of the applications, it's needed to get them back.

See commits: https://github.com/pkp/pkp-lib/commit/3fd04e52fcc8366f99096c45a5e8d48819d812e7 https://github.com/pkp/ojs/commit/9518b9e4d2c97d656a3a00b4b9c0c0b999f78b5b

What application are you using? OJS/main

jardakotesovec commented 6 days ago

@jonasraoni let me know if you need any help with this.. debugging cypress tests day&night..

jonasraoni commented 6 days ago

Feel free to take a look! I've already assigned too many tasks to myself 😂

I guess it's a Cypress concurrency issue. When I logged into the GitHub machine and executed the test individually, it worked. Also, on a couple of PRs, it has a non-stable behavior (here for example, 2 worked, 3 failed: https://github.com/pkp/omp/actions/runs/9590188958), but suddenly it started to fail always.