search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
297 stars 443 forks source link

Move publication to issue_id relationship out of publication_settings table #10157

Open asmecher opened 2 months ago

asmecher commented 2 months ago

Describe the bug Raised in https://github.com/pkp/pkp-lib/discussions/7975 and elsewhere:

Storing the issue ID for the publication in the publication_settings table is problematic for several reasons:

For these reasons, the issue ID should instead be stored as an issue_id column in publications.

Note that this column will apply to OJS only, as OMP and OPS don't have issue-based publication!

Hafsa-Naeem commented 1 month ago

@asmecher Ready for review

OJS_main:

Hafsa-Naeem commented 3 weeks ago

@asmecher @jonasraoni Ready for review again OJS_main pkp/pkp-lib#10157 Moved issueIds out of publication_settings #10298

asmecher commented 2 weeks ago

Added a comment, thanks! https://github.com/pkp/pkp-lib/pull/10298#issuecomment-2313405065