pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
297 stars 442 forks source link

Move publication to category relationship out of publication_settings #10158

Open asmecher opened 2 months ago

asmecher commented 2 months ago

Describe the bug Raised in https://github.com/pkp/pkp-lib/discussions/7975 and elsewhere:

Storing the category IDs for the publication in the publication_settings table is problematic for several reasons:

For these reasons, the category IDs should instead be stored in a separate table. I suggest using an Eloquent model as discussed in https://github.com/pkp/pkp-lib/discussions/8103 and as implemented in e.g. the UserUserGroup model.

Hafsa-Naeem commented 1 month ago

@asmecher I've submitted a Draft PR which is currently under progress. pkp/pkp-lib#10158 Move categoryids out of of publication_settings

Hafsa-Naeem commented 1 month ago

@asmecher Ready for review OJS_3_4_0 pkp/pkp-lib#10158 Move categoryids out of of publication_settings

asmecher commented 1 month ago

Reviewed, thanks, @Hafsa-Naeem! https://github.com/pkp/pkp-lib/pull/10247#pullrequestreview-2208482792

Hafsa-Naeem commented 1 month ago

@asmecher Ready for review. Based on the code review comments, I've added the changes in the main branch. PR: OJS_main: pkp/pkp-lib#10158 Move categoryids out of of publication_settings

Hafsa-Naeem commented 1 month ago

Ready for review again @asmecher and @jonasraoni I've also added comment that could use your insights. OJS_main: pkp/pkp-lib#10158 Move categoryids out of of publication_settings #10265

Hafsa-Naeem commented 3 weeks ago

@asmecher Ready for review again OJS_main: pkp/pkp-lib#10158 Move categoryids out of of publication_settings #10265

Hafsa-Naeem commented 2 weeks ago

@asmecher @jonasraoni I've addressed this missing comment