search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
297 stars 442 forks source link

Fix usage/implementation of $urlLocaleForPage at the PKPRouter::url() #10242

Open jonasraoni opened 1 month ago

jonasraoni commented 1 month ago

Describe the bug On the PR https://github.com/pkp/pkp-lib/pull/9628 a parameter called $urlLocaleForPage was introduced, but in a couple of places its usage seems to be incorrect or missing something, it's needed to review and apply fixes.

For example, the PKPRouter doesn't have the argument $urlLocaleForPage, but it's being used here: https://github.com/pkp/pkp-lib/blob/c111708049c9ae8246a22a35aa440b6a35d8c7f9/classes/template/PKPTemplateManager.php#L280

What application are you using? OJS 3.5

asmecher commented 1 month ago

@ajnyga, heads-up: this is related to https://github.com/pkp/pkp-lib/issues/699

ajnyga commented 1 month ago

Thanks, tagging @jyhein here since I can not assign him directly,