Open jonasraoni opened 1 month ago
Describe the bug On the PR https://github.com/pkp/pkp-lib/pull/9628 a parameter called $urlLocaleForPage was introduced, but in a couple of places its usage seems to be incorrect or missing something, it's needed to review and apply fixes.
$urlLocaleForPage
For example, the PKPRouter doesn't have the argument $urlLocaleForPage, but it's being used here: https://github.com/pkp/pkp-lib/blob/c111708049c9ae8246a22a35aa440b6a35d8c7f9/classes/template/PKPTemplateManager.php#L280
What application are you using? OJS 3.5
@ajnyga, heads-up: this is related to https://github.com/pkp/pkp-lib/issues/699
Thanks, tagging @jyhein here since I can not assign him directly,
Describe the bug On the PR https://github.com/pkp/pkp-lib/pull/9628 a parameter called
$urlLocaleForPage
was introduced, but in a couple of places its usage seems to be incorrect or missing something, it's needed to review and apply fixes.For example, the PKPRouter doesn't have the argument
$urlLocaleForPage
, but it's being used here: https://github.com/pkp/pkp-lib/blob/c111708049c9ae8246a22a35aa440b6a35d8c7f9/classes/template/PKPTemplateManager.php#L280What application are you using? OJS 3.5