search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
305 stars 444 forks source link

Issue PDF galley page missing locale key submission.representationOfTitle #10559

Open NateWr opened 2 hours ago

NateWr commented 2 hours ago

Describe the bug When an issue galley is displayed in the reader interface using pdfJsViewer, the iframe title attribute has a missing locale key:

<iframe
  title="##submission.representationOfTitle##"
  ...
>

To Reproduce Steps to reproduce the behavior:

  1. Upload a PDF as an issue galley in Issues > (issue) > Issue Galleys.
  2. Publish the issue, view it in the reader interface, and click to view the galley.
  3. Inspect the source code to see the missing title attribute.

What application are you using? OJS 3.3.x. I believe this only effects 3.3. If I remember correctly, from 3.4 we don't have to manually load locale files.

Additional information PR coming in a second.

NateWr commented 2 hours ago

PR: https://github.com/pkp/pdfJsViewer/pull/75

Tests: https://github.com/pkp/ojs/pull/4488