search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
307 stars 447 forks source link

OJS - 3.5 - Viewing submission without review stage will display an error when selecting review from side workflow navigation option #10626

Open Tribunal33 opened 1 day ago

Tribunal33 commented 1 day ago

Describe the bug When selecting the Review option from the side navigation workflow option within a submission view, that does not have a Review Round created results in an error and greyed out background blocking user.

To Reproduce Steps to reproduce the behavior:

  1. Go to VM of you choice (ex https://jarda.testing.publicknowledgeproject.org/index.php/publicknowledge/en/)
  2. Login with any user (admin used for testing)
  3. Under Dashboards -> active submissions select a submission without a Review Round
  4. Select Rossi -> View button
  5. Open up dev tools to view console error
  6. From the new window pane Select Review from side nav Workflow option
  7. If error is not seen select different side nav option first then select Review option after
  8. Observe error in consoleExpected: No error and pane updates correctly

Actual: Pane closes and grey background is unclickable for user. Error is in the dev tools (see updated image):

Additional information Please add any screenshots, logs or other information we can use to investigate this bug report. Updated image Image

Old Image Image

Tribunal33 commented 1 day ago

@jardakotesovec I have updated the local branch and tried again. The UI no longer crashes with a grey background but an error is still present due to null object. Will add another screenshot for reference.

Additionally, the there are added steps since the default already has the review option highlight you will first need to select another option and then back to the Review option.

I will lower the severity as well.