Multilingualism - Githubissues

bozana commented 8 years ago

There are a few issues concerning multilingualism, that need attention, s. forum.pkp.sfu.ca/t/ojs3-and-multilingual-journals/19452/ and http://forum.pkp.sfu.ca/t/how-to-go-about-multilinugual-welcome-text-on-the-index-ojs-3-0/17002/5 and http://forum.pkp.sfu.ca/t/names-of-localizations-in-text-boxes-and-fields/21049

[x] a) TinyMCE fields do not contain language designation, so that the user doesn't know where to write in which language. PR: https://github.com/pkp/pkp-lib/pull/2474
[x] b) Some input fields (e.g. additional submission metadata fields like language and keywords) also do not have language designation. PR: https://github.com/pkp/pkp-lib/pull/2499 and https://github.com/pkp/pkp-lib/pull/2510
[ ] c) Is the logo upload meant to be like at the moment: to switch UI language in order to upload the logo in that language? -- Yes, currently it is so, till a multilingual file upload is not implemented/solved.
[x] d) First, the input field in the current UI language is displayed. This makes the required fields required for that UI locale (instead of submission locale) in the submission metadata form for editors. Solved here:https://github.com/pkp/pkp-lib/issues/2114
[x] e) The author submission step 3 (metadata) fields are validated against journal primary locale and not submission locale. Solved here:https://github.com/pkp/pkp-lib/issues/2114
[x] f) A strange effect: Lets say the submission locale is English and there is the submission title in English, primary locale and the UI language is German. When an editor opens submission metadata (UI = German), then cuts the English title and inserts it as German title (because it is marked as required, s. d) above), and then saves the form, the title will be saved as English title. Solved here:https://github.com/pkp/pkp-lib/issues/2114

Ph-We commented 7 years ago

Hi! I would also like to add Roles titles to this. Since those are displayed on pages and depend on language too. See here: http://forum.pkp.sfu.ca/t/ojs3-user-roles/23372

asmecher commented 7 years ago

@Ph-We, just glancing quickly over the code, role names should already be localized. Perhaps it's a minor bug rather than a missing feature?

Ph-We commented 7 years ago

@asmecher, thank you! Yes, now I've found what caused Roles not being localized. Sorry, my bad.

asmecher commented 7 years ago

@Ph-We, no problem!

bozana commented 7 years ago

I am not familiar with those issues i.e. do not know the solution immediately, thus either someone else does or could we defer it to 3.0.2?

asmecher commented 7 years ago

Agreed!

Ph-We commented 7 years ago

Hi @bozana, @asmecher,

The "Publisher" field (in the Masthead) is not multilingual. Is there any reason for this? It is important for it to be multilingual for journals to be indexed correctly.

asmecher commented 7 years ago

Hi @Ph-We -- see http://forum.pkp.sfu.ca/t/publisher-name-in-multilingual-journals/27557 for a discussion of this field.

ajnyga commented 7 years ago

Hi @bozana, especially issue a here is important for us since many of our journals are multilingual. I am using this very simple approach to solve it: https://github.com/pkp/pkp-lib/compare/master...ajnyga:fix1807a?expand=1

That basically appends the name of the language before the tinymce box: screenshot_14

Below my code is an original code involving flag related css classes. Maybe that is an attempt to solve the same issue? But as you probably know using flags is not a good option.

rkhalikov commented 7 years ago

I'd like also to pay attention that for the following fields there is no possibility to add information in several languages:

Contact -> Mailing Address
Contact -> Principal Contact Name and Technical Support Contact Name (whereas Affiliation is multi language...)

asmecher commented 7 years ago

@NateWr, would you mind having a look at a) in the original entry and @ajnyga's post and commit? It looks like the :focus selector doesn't work with TinyMCE elements, thus the language label on TinyMCE fields doesn't work. I think there's likely a CSS-only solution available but I'd be wasting everyone's time tinkering with it myself :)

NateWr commented 7 years ago

I chose to fix this in the template files themselves. It's basically the same as @ajnyga's fix.

selection_199

PR: https://github.com/pkp/pkp-lib/pull/2474

TESTS ONLY: https://github.com/pkp/ojs/pull/1367

bozana commented 7 years ago

@NateWr, could you take a look at this PR: https://github.com/pkp/pkp-lib/pull/2499 ?

NateWr commented 7 years ago

Looks good @bozana. Would you take a look at my PR just above?

https://github.com/pkp/pkp-lib/issues/1807#issuecomment-297303569

Tests passed before (just one timeout), but I've rebased it again for clean merging.

bozana commented 7 years ago

@NateWr, it looks good :-) I just do not know if the tests failing is connected with the Travis issue @asmecher mentioned and he is working on, s. https://github.com/pkp/pkp-lib/issues/2495? -- I think so... Thus, do you think we can merge?

bozana commented 7 years ago

Hmmm... I will merge it now and then later run the major tests locally... and if there is a problem I will try to solve it...

bozana commented 7 years ago

Everything merged, thus closing...

pkp / pkp-lib

Multilingualism #1807