search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
297 stars 443 forks source link

Add custom review forms to reviews report #2051

Closed jmacgreg closed 1 year ago

jmacgreg commented 7 years ago

Custom review forms aren't currently included in the "Comments" column of the Reviews report. Consider adding.

asmecher commented 3 years ago

There's an equivalent implementation for importing review form content into the email to the author over here: https://github.com/pkp/pkp-lib/blob/b05058877f7c2d08d0f919e6349ee2c02fa28ea6/classes/controllers/modals/editorDecision/PKPEditorDecisionHandler.inc.php#L242..L284

This is live/working in OJS 3.x already, so would make a good reference. Bonus points if the code is reused rather than copypasta'd.

asmecher commented 3 years ago

Merged https://github.com/pkp/reviewReport/pull/39 to implement this -- thanks, @jnugent! Jason, have you built a plugin package before?

NateWr commented 2 years ago

@asmecher can this issue be closed?

asmecher commented 2 years ago

No, I think it should still be an active feature request.

bozana commented 1 year ago

@asmecher, this is already merged. What would be still needed to do in this issue? The plugin would maybe/probably need to be adapted to 3.4, but this is another issue, I think.

asmecher commented 1 year ago

Agreed, I probably missed the note about the plugin PR when reviewing this earlier. Closing.