search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
297 stars 443 forks source link

[OJS] Provide option to restrict low-level editors to "recommend" only, not make decisions #2433

Closed jmacgreg closed 7 years ago

jmacgreg commented 7 years ago

We've received this request from numerous science journals. They often have one or more senior editors who are overall responsible for submissions, and can make decisions, etc.; and lower-level editors who manage the review process but can only make recommendations, not editorial decisions.

The request would be to provide a configurable option at the role level to restrict said role to recommend only, not to be able to decide. This would be reflected in the review stage only. Such editors would see a "Recommend" button rather than the accept/reject buttons; and the "Recommend" button wouldn't commit an action, but would send an email to all recorded senior editors, and would be recorded in the history.

bozana commented 7 years ago

OMP PR also made. When the tests pass I will merge... if no objection... :-)

asmecher commented 7 years ago

@asmecher, I modified one of the existing submissions tests to test the recommendation -- I hope that's OK so... ?

Yes, of course! I've been falling behind in ensuring test coverage of new work, so nice to see this.

paolocasarini commented 7 years ago

Do you think it's possible to merge this feature also on the 3.0 branch?

bozana commented 7 years ago

No, I don't think so -- 3.0 is too old ;-) -- from 3.0 to 3.0.2 a lot of changes and improvements happened and this change is made even later, after lots of 3.0.2 improvements happened... But soon the 3.1 will be released, so that you could consider an upgrade... :-)