pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
299 stars 443 forks source link

[OJS3] Disallow/Trim excessive spaces in names #5076

Open Ph-We opened 5 years ago

Ph-We commented 5 years ago

Describe the bug Any excessive space in a contributor name entered (leading, trailing, double space) would make this name different from the same name entered without excessive spaces. This would result in creation of a new author profile, even if the email is the same. https://forum.pkp.sfu.ca/t/ojs-3-disallow-excessive-spaces-in-names/55816

What application are you using? OJS 3.1.2-1

asmecher commented 5 years ago

@Ph-We, author records are intentionally not deduplicated, i.e. two articles with the same author information will result in two author records. Where are you seeing problems caused by spacing differences in entered names?

Ph-We commented 5 years ago

@asmecher, you've surprised me, so I hope we could discuss it further here: https://forum.pkp.sfu.ca/t/ojs-3-disallow-excessive-spaces-in-names/55816

Technically speaking, our journal managers ask us how they could build author indexes. All we can offer is something like this: https://jle.hse.ru/search/authors Which obviously does not work as expected. The good thing is at this point authors are more or less 'deduplicated': https://jle.hse.ru/search/authors/view?givenName=Nasy%20Inthisone&familyName=Pfanner However, these two queries would still give two different results:

  1. https://jle.hse.ru/search/authors/view?givenName=Nasy%20Inthisone&familyName=Pfanner
  2. https://jle.hse.ru/search/authors/view?givenName=Nasy%20%20Inthisone&familyName=Pfanner (double space) This is why I'd propose to get rid of any excessive spaces.
asmecher commented 5 years ago

@Ph-We, let's keep the discussion over there for now. I'll follow up.