search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
297 stars 444 forks source link

Improve search function where dropdown options are available #6263

Open pmangahis opened 3 years ago

pmangahis commented 3 years ago

Describe the problem you would like to solve When using the User-Search function after choosing the user role, one has to click 'Search' for all users with the role to be displayed.

Describe the solution you'd like After the user has chosen the role from the drop-down menu the search results should be shown without clicking 'search'. Another example of this would be when adding a discussion at a discussion. The 'journal manager' role is preselected and all possible journal managers are listed. But when changing to 'section editor' you have to click 'search' (while leaving the name field empty) to get all possible 'section editors' displayed. So, choosing the role from the drop-down menu should execute the search.

Who is asking for this feature? Journal Editors, Editor-in-Chief

Additional information Client is currently on OJS 3.1.2.4, but I've also tried this on OJS 3.2.1.1

NateWr commented 3 years ago

We avoid performing a search when a select dropdown has occurred because of accessibility issues. When using assistive technology, the user must "select" each option in order to hear it read, which leads to a lot of noise when the list is updated with each selection.

This will be addressed in https://github.com/pkp/pkp-lib/issues/2860 when we introduce a ListPanel for users. We'll implement similar searching/filtering patterns to the submission lists.