search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
306 stars 445 forks source link

DOI assignment message is unclear when issue has no volume or number #6435

Open bozana opened 3 years ago

bozana commented 3 years ago

Describe the bug The DOIs that contain the %i (issue variable) in their suffix cannot be assigned to an article -- there is always the message "You can not generate a DOI until this publication has been assigned to an issue" (also if the article is assigned to an issue). This is not the case for galleys.

To Reproduce Steps to reproduce the behavior: Having DOI plugin enabled and set to use e.g. the default DOI sufix:

  1. As editor go to an article
  2. Click on the tab 'Publication'
  3. Click on the menu 'Issue' and assign an issue to the article
  4. Click on the menu 'Identifiers'
  5. See the message 'You can not generate a DOI until this publication has been assigned to an issue'

What application are you using? OJS version 3.3 master branch

Additional information Please add any screenshots, logs or other information we can use to investigate this bug report.

NateWr commented 3 years ago

I was unable to reproduce this myself. When a publication is assigned to an issue, the form response should update the publication's object in the browser, and this should get passed down to the Identifiers form, so that the DOI field is updated and it is possible to generate a DOI.

Can you check your browser's console log when assigning to an issue to see if there is some error that may be occurring?

bozana commented 3 years ago

Hmmm... Strange... I do not see any errors (just a warning for the OJSSID cookie)... The article DOI field is always disabled with that message, also when the article is assigned to an issue and then I do something else and then go back to the article... I'll investigate further...

bozana commented 3 years ago

Oh, thanks to @NateWr, we figured out that my issue is only identified by the title and there is no issue number there... Thanks!

NateWr commented 3 years ago

I've updated this issue to reflect that it's primarily a UX issue. The DOI assignment field will show a warning when it can't assign a DOI because it does not have the correct data from an issue. This warning says something like:

You must assign this to an issue before you can assign a DOI.

However, this warning can be encountered even if a submission is assigned to an issue, if that issue does not have a volume or number. This is probably rare, but the warning message should be updated to reflect this, or distinct warning messages should be created to identify what is missing.