search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
304 stars 444 forks source link

OMP 3.3 - Metadata Keyword displaced causing tip box information permanently open #6569

Open israelcefrin opened 3 years ago

israelcefrin commented 3 years ago

Describe the bug When there's a keyword for the publication and you click the "?" to check info about "type", the word moves into the field above and it is not possible to close the info box.

To Reproduce Steps to reproduce the behavior:

  1. Choose a submission with has keywords
  2. Go to the 'Submission page'
  3. Click on 'Publication > Metadata'
  4. Click on "Type ? " to open its modal info
  5. See error

What application are you using? OMP version 3.3

Additional information

https://user-images.githubusercontent.com/4992902/104241847-43ef9100-542c-11eb-9aa8-f41c4b71b25f.mov

asmecher commented 3 years ago

@NateWr, assigning this one to you, thanks!

NateWr commented 3 years ago

@israelcefrin I'm unable to reproduce a case where the keyword is shown below the input area, and then when clicking elsewhere the keyword is moved up into the input area. From the video, it looks like the shift possibly happens on a blur event, though the method to move keywords in/out of the input is not attached to a blur event. It could be that the blur is causing an undetectable change in the element size. But from the video, the keyword water should never have appeared below the input area anyway. It fits in the input area with plenty of space.

When you reload the page, does the water keyword always stay below the input area?

israelcefrin commented 3 years ago

@NateWr I've tested on Chrome, Firefox and Safari (all for Mac). Firefox is the only one that doesn't show the keyword below the input field. The 2 others, even reloading, keep showing the keyword misplaced.

NateWr commented 3 years ago

The 2 others, even reloading, keep showing the keyword misplaced.

Do you mean the keyword appears within the input area? (That's where it should appear.)

NateWr commented 1 year ago

I've reassigned this to @pkp-dev-distribution, but it's probably something for @jardakotesovec to pick up. We've had persistent problems with the tooltips being misaligned or not closing when clicked outside of. It might make sense to re-assess the use of tooltips or the library we're using.