Closed asmecher closed 3 years ago
@defstat, could you put together a build of the PKP|PN plugin for OJS 3.3?
@withanage, could you put together a build of the Texture plugin for OJS 3.3?
@bozana, could you put together a build of the Paperbuzz plugin for OJS 3.3?
@withanage, could you also do LensGalleyBits?
@jonasraoni, is the registration notification plugin compatible with OJS 3.3.0?
@NateWr, is the Control Public Files plugin compatible with 3.3? If not, could you make a new release for it?
@NateWr, likewise for Text Editor Extras?
@ajnyga, do you know if the Returning Author screening plugin is compatible with 3.3.0?
Still needing my attention:
@jonasraoni, is the registration notification plugin compatible with OJS 3.3.0?
@asmecher I've just checked, and it works... But I found some generic issues, I've opened these issues:
About the Portico, I've created PRs for the 3.x branches, I've just made a fast test against each version and it seems to be ok.
@defstat, could you put together a build of the PKP|PN plugin for OJS 3.3?
@asmecher in order to do that we have to
I tested textEditorExtras
and controlPublicFiles
. Neither needed a new release so I updated the compatibility statements in https://github.com/pkp/plugin-gallery/commit/5c99edb50e97310cc672d40b551ffa70bc42b7a1. I noticed that there are some translation updates since the last release, though. Should I make new releases for them?
I noticed that there are some translation updates since the last release, though. Should I make new releases for them?
We don't have a firm policy on that. I released a few plugins that only had translation changes, as it wasn't much extra effort. I've also been updating our copyright dates, which feels like and appears to be busywork, for what that's worth. I do think that by the time a few translations accumulate we should do the translators the service of releasing their work.
@jonasraoni, on the registration notification plugin issues, let's leave those for post-3.3.0 and I'll flag the current version of the plugin as compatible with 3.3.0 (or release a new version if there are enough new translations around).
@defstat:
perhaps make a branch tagging 3.3? Or should we continue with the master branch instead?
I have been avoiding mass-creating branches to distinguish stable-3_3_0
from ongoing dev (currently master
but that should change to unstable
or Github's new default, main
). But we should do that for important plugins that are likely to receive active development on several branches, including the PKP|PN plugin. There is already a stable-3_2_1
branch for maintaining 3.2.1 compatibility, so the master
branch can be considered compatible with 3.3.0. When we start dev work on 3.4 and need to break that compatibility, then we should create a stable-3_3_0
branch.
@asmecher, I've updated the AuthorRequirements plugin and made a PR to the plugin-gallery. Thanks!
PR: pkp/plugin-gallery#33
@asmecher initial release of the Advanced Search plugin, with a PR to the plugin-gallery. (It also works in 3.2.x) PR: https://github.com/pkp/plugin-gallery/pull/34
Moving to 3.3.0-3 for tracking of the rest -- none are crucial for 3.3.0.
Updates for customLocale, textEditorExtras and controlPublicFiles are complete.
Update for paperbuzz is complete... I've also merged the PR for plugin-gallery...
Added pkp/plugin-gallery#38 for PKP|PN for OJS 3.3.0-x
@asmecher do you want to do a new code review for the upgraded plugins? Mainly thinking about the changes to DAOs due to adodb. Funding plugin seems to be working but worried that I am missing something https://github.com/ajnyga/funding
@ajnyga, I took a glance over the funding plugin code (particularly the DAOs), and they look like they've been well adapted for the ADODB changes! (But feel free to get rid of those pesky PHP closing tags if you like.) Thanks!
@asmecher OpenGraph, Funding and OpenAIRE can be marked as ready above.
With AllowedUploads I run into a bug in the SubmissionFile::validator error handling that the plugin is trying to use. Nate is looking into that. The bug seems to be in the core, the plugin itself should actually work already, but I will do a release once I hear from Nate.
Updated, thanks, @ajnyga!
Hi @NateWr and @asmecher ,
I know this is probaly not high priority, but I found the pluginTemplate Repository linked in the Developer Docs (https://docs.pkp.sfu.ca/dev/plugin-guide/en/examples) and was wondering if this has been Updated for 3.2 or 3.3?
https://github.com/pkp/pluginTemplate
It would be a great starting point for colleagues who start working on OJS/OMP generic Plugins. Especially with the new Vue.js Forms and Schema.
Thanks for doing such a great work,
Nils
@isgrim, I took a look at https://github.com/pkp/pluginTemplate and it doesn't use any features that are different between 3.1.2 and 3.3.x, i.e. it should still work with newer releases.
@asmecher
Following PR https://github.com/pkp/plugin-gallery/pull/45 adds Texture support for OJS 3.3
(Dimitris Sioulas, National Documentation Center)
(Alec Smecher, Public Knowledge Project)
(Chris Maden, University of Illinois)
(Alec Smecher, Public Knowledge Project)
(Alec Smecher, Public Knowledge Project)
(Alec Smecher, Public Knowledge Project)
(Dimitris Efstathiou, Public Knowledge Project)
(Alec Smecher, Public Knowledge Project)
(Antti-Jussi Nygård)
(Alec Smecher, Public Knowledge Project)
(Svantje Lilienthal, Freie Universität Berlin)
(Alec Smecher, Public Knowledge Project)
(Oleksii Vodka, National Technical University Kharkiv Polytechnic Institute)
(Alec Smecher, Public Knowledge Project)
(Antti-Jussi Nygård)
(Alec Smecher, Public Knowledge Project)
(Public Knowledge Project, Public Knowledge Project)
(Alec Smecher, Public Knowledge Project)
(Alec Smecher, Public Knowledge Project)
(Alec Smecher, Public Knowledge Project)
(Alireza Sokhandan)
(Nate Wright, Public Knowledge Project)
(Vitaliy Bezsheiko, Public Knowledge Project)
(Vitaliy Bezsheiko, Public Knowledge Project)
(Nate Wright, Public Knowledge Project)
(Dulip Withanage, Public Knowledge Project)
(Bozana Bokan, Public Knowledge Project)
(Vitalii Bezsheiko, Public Knowledge Project)
(Dulip Withanage; Clinton Graham; Nils Weiher, Public Knowledge Project; Pittsburgh University; Heidelberg University)
(Alec Smecher, Public Knowledge Project)
(Bozana Bokan, Public Knowledge Project)
(Antti-Jussi Nygård, OJS-de.net)
(Dulip Withanage, University of Heidelberg)
(University Library System, University of Pittsburgh)
(University Library System, University of Pittsburgh)
(University Library System, University of Pittsburgh)
(University Library System, University of Pittsburgh)
(University Library System, University of Pittsburgh)
(Erik Hanson, Public Knowledge Project)
(Public Knowledge Project, Public Knowledge Project)
(Public Knowledge Project, Public Knowledge Project)
(Public Knowledge Project, Public Knowledge Project)
(Ronny Bölter, Leibniz Institute for Psychology Information)
(Ronny Bölter, Leibniz Institute for Psychology (ZPID), Trier, Germany)
(Public Knowledge Project, Public Knowledge Project)
(Public Knowledge Project, Public Knowledge Project)
(Antti-Jussi Nygård, The Federation of Finnish Learned Societies)
(Publons, Publons)
(Sophy Ouch, Public Knowledge Project)
(Manuel Campechano, eScire)
(Public Knowledge Project, Public Knowledge Project)
(Ronny Bölter, Leibniz Institute for Psychology (ZPID), Trier, Germany)
(Public Knowledge Project, Public Knowledge Project)
(Dulip Withanage, German National Library of Science and Technology (TIB), Hannover, Germany )
(Public Knowledge Project, Public Knowledge Project)
(Matteo Mondini, ReviewerCredits)