Closed NateWr closed 1 year ago
@NateWr, could you please review the PRs above?
Looks good @bozana! I've left a few comments with possible bugs, but it's mostly stylistic suggestions. Go ahead and merge once you're happy with it. :+1:
Thanks a lot @NateWr!
The
section
entity needs to be converted to use the new pattern for DAOs, Maps and Repositories introduced in #5328. This requires the following:EntityDAO
and use type hints.SectionService
to a repository .SectionService::getProperties()
to a Map that extendsPKP\core\maps\SchemaMap
.SectionService
so that direct access to the DAO is not required.DAORegistry::getDAO('SectionDAO')
to use the repository instead.PRs:
Further PRs: