search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
307 stars 447 forks source link

Non-english Paypal email template in OJS 3.3.0 #7300

Open israelcefrin opened 3 years ago

israelcefrin commented 3 years ago

Describe the bug When deploying a fresh install of OJS, the Paypal email template (PAYPAL_INVESTIGATE_PAYMENT) should be in English locale, but it presents the Ukrainian version.

To Reproduce Steps to reproduce the behavior:

  1. Deploy a fresh OJS 3.3 and create a journal
  2. Click on 'Workflow > Emails > Email Templates'
  3. Search for 'Paypal'
  4. See error

What application are you using? OJS 3.3.0

Additional information The database shows the en_US key with the wrong locale text: image

There is a closed issue from 2015 with the same issue reported: https://github.com/pkp/pkp-lib/issues/317

It is an issue since OJS2: OJS3 - https://forum.pkp.sfu.ca/t/other-language-appearing-in-english-language-email-paypal-template/62926 OJS2 - http://wayback.archive-it.org/7100/20160820193253/https://pkp.sfu.ca/support/forum/viewtopic.php?f=8&t=13734#p52537

NateWr commented 3 years ago

@israelcefrin was this really 3.3.0 or another one like 3.3.0-x? I think we may have fixed a similar issue in one of the -x upgrades.

israelcefrin commented 3 years ago

@NateWr it was noticed on an OJS 3.3.0-7 fresh install.

pmangahis commented 2 years ago

This is also appearing on fresh 3.2 installs (3.2.1.1) as well.

bozana commented 2 years ago

Hmmm... Strange... I cannot reproduce it, neither with the current stable-3_3_0 branch nor with the tag 3_3_0-7 :thinking:

bozana commented 2 years ago

I've just tried it with the current stable-3_2_1 and could not reproduce it. @pmangahis, would it be possible for you to give me some more information? Maybe what languages have you installed and how (all during the installation, or later)? Also maybe if you have done any further settings after the installation? Any major steps you make... Thanks a lot!

pmangahis commented 2 years ago

@bozana I just installed 3_2_1 (only English installed) again and do not see this issue anymore. It looks like we're also installing 3.3 for new clients at this point. I did see this broken email template on a fresh journal we installed in August 2022 (3.3.0.7). I will ask the systems team to comment on this

joshnoronha commented 2 years ago

@bozana I set up a 3.3.0.7 install in August and the issue is there (only English installed, as Patricia). I did not noticed it until now, since the client does not use Paypal.

bozana commented 2 years ago

Thanks a lot @pmangahis and @joshnoronha. It seems this issue appears now and then, not regularly :-( This makes it extreme hard to debug and figure out what is going wrong :-( Are there maybe any other installs since August, and if they have the same problem?

joshnoronha commented 2 years ago

@bozana I've just checked another install, also in sfulib4 and OJS 3.3.0.7, and everything is working fine. I tried to find a pattern, but no luck, both installs are exactly the same, except one of them has the Paypal issue.

bozana commented 2 years ago

Thanks a lot @joshnoronha! Yes, very strange... :thinking:

asmecher commented 2 years ago

I'm content to defer this to 3.3.0-13 -- though of course a resolution (and/or reliable reproduction steps) would always be welcome!