search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
297 stars 443 forks source link

Save user preferred language #7702

Open forgive38 opened 2 years ago

forgive38 commented 2 years ago

Describe the problem you would like to solve In order to know in which language a email should be sent (https://github.com/pkp/pkp-lib/issues/3525), I propose to add "preferred language" or "corresponding language" as a new setting to the user profile

Describe the solution you'd like I think this should be a new item in the registration form - pre-populated by the browser language. At the same time, we could ask for working languages, which could be used to solve this issue (https://github.com/pkp/pkp-lib/issues/6221)

Who is asking for this feature? Journal Editors, Journal Administrators

Additional information Some mockups to discuss the UI: New user: Screenshot 2022-02-15 at 12-08-27 Register ojs main or display as an array:

Screenshot 2022-02-15 at 10-28-51 Register ojs main

When creating a new reviewer: Screenshot 2022-02-15 at 12-19-24 ceci est le 2 etest ojs main

asmecher commented 2 years ago

@forgive38, I think this is already covered by https://github.com/pkp/pkp-lib/issues/7293 and https://github.com/pkp/pkp-lib/issues/7512; are there aspects that are different here?

NateWr commented 2 years ago

@asmecher I asked Simon to file this in this comment. It differs from #7293 and #7512 because those are about the session language (ie - what UI am I looking at right now). This is about capturing data about what languages the user prefers to work in.

@forgive38 let's keep this issue focused on capturing the user's language preferences. Each use of a preferred language (eg - in the reviewer assignment email, reviewer selection, automated emails, etc) will require slightly different implementations, and we have separate issues filed already.

Can I suggest a different wording of the "problem"?

In a multilingual journal, it is sometimes important to know what languages a user can work with. This can be important when sending emails (https://github.com/pkp/pkp-lib/issues/3525), selecting reviewers (https://github.com/pkp/pkp-lib/issues/6221), or selecting editors/assistants. However, most users have not set the working languages setting in their user profile.

Then the "solution" can be along these lines:

In multilingual journals, ask new users to provide their working languages when they sign up. Select the browser's current language by default so that users have at least one language by default.

I know this is basically what you've said. But I want to try to be really clear about the purpose / goals before we try to figure out the best solution.

asmecher commented 2 years ago

Gotcha -- thanks, @NateWr and @forgive38!

asmecher commented 2 years ago

PRs from @forgive38:

@NateWr, could you have a look at these?

NateWr commented 2 years ago

I'm concerned about moving forward with this without having much clear feedback from our community on the use-cases behind this. This PR would give us two nearly identical fields ("working languages" and "preferred languages"), which will contribute to confusion.

Normally, I'd suggest we workshop this a little bit to gather feedback and design a solution that is appropriate for the different use cases, with minimal impact on the end user. But right at this moment, I don't have the time to lead that process and we don't have anyone else to do it either.

I think, to move forward, at a minimum we need more community input.

forgive38 commented 2 years ago

OK, one point of UI improvement could be keeping "preferred language" for communicating purpose and as default working language, and users could choose "other working languages" (preferred language won't be in this second list)