search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
297 stars 443 forks source link

Drop unsupported MySQL driver #8099

Open jonasraoni opened 2 years ago

jonasraoni commented 2 years ago

Describe the bug The support for the old MySQL driver has been dropped in PHP 7.0, so we can do the same, at least for the main branch.

PRs

What application are you using? */main

jonasraoni commented 2 years ago

@asmecher Just dropped some references to the MySQL extension.

asmecher commented 2 years ago

@jonasraoni, these have the effect of disturbing legacy code without really improving things; personally, I'd rather wait until we're able to remove the ADODB support entirely rather than introducing code churn there.

To remove DBTYPE=MySQLi in favour of MySQL, you'd also need to update https://github.com/pkp/datasets/blob/df29c67e2414ec6b0a3665021092a3806e0844fe/tools/environment.sh#L66 -- and it's possible that other third parties are using this as well.

If you'd like to remove the parts of this that change the handling of DBTYPE, I'd consider merging it.