search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
306 stars 445 forks source link

Thanking reviewer is throwing internal exception. #8111

Closed touhidurabir closed 2 years ago

touhidurabir commented 2 years ago

Describe the bug When thanking a reviewer, it throws internal exception and the Thank Reviewer modal is not closing at done .

To Reproduce Steps to reproduce the behavior:

  1. Create a submission and push it to External Review stage.
  2. Invite a reviewer, complete the review process and submit it.
  3. Login as Editor and confirm the submitted review by reviewer.
  4. Try to thank the reviewer and see that the modal is not going away even though the mail went through .

What application are you using? OJS OMP in the main branch.

Additional information Error Log

PHP Fatal error:  Uncaught Error: Class "SubmissionEmailLogEntry" not found in /INSTALLED_PATH/lib/pkp/controllers/grid/users/reviewer/form/ThankReviewerForm.inc.php:123

In addition, the mentioned class ThankReviewerForm has several class use statement missing .

touhidurabir commented 2 years ago

@asmecher please review the PRs. As this is a trivial fix, I have made PR for all .

pkp-lib --> pkp/pkp-lib#8111 added missing use class statements ojs --> pkp/pkp-lib#8111 Submodule Update ##touhidurabir/i8111_main## omp --> pkp/pkp-lib#8111 Submodule Update ##touhidurabir/i8111_main## ops --> pkp/pkp-lib#8111 Submodule Update ##touhidurabir/i8111_main##

NateWr commented 2 years ago

Thanks @touhidurabir. It looks like one test failed for each app. Probably just a fluke but I've restarted them to be sure. Can you let me know when they've passed?

touhidurabir commented 2 years ago

@NateWr , the OJS tests have passed for stage 2. But for OPS and OMP it has failed for one of each instances .

For OPS, it shows error as 

Cypress failed to start.
This is usually caused by a missing library or dependency.
The error below should indicate which dependency is missing.
https://on.cypress.io/required-dependencies
If you are using Docker, we provide containers with all required dependencies installed.
----------
Command failed: /home/travis/.cache/Cypress/4.12.1/Cypress/Cypress --no-sandbox --smoke-test --ping=958
----------
Platform: linux (Ubuntu - 18.04)
Cypress Version: 4.12.1
The command "./lib/pkp/tools/travis/run-tests.sh" exited with 1.

for OMP it's shows as 

Create a submission:
     AssertionError: Timed out retrying: Expected to find element: `input[id^="title-en_US-"`, but never found it.
      at Context.eval (http://localhost/__cypress/tests?p=cypress/support/index.js:847:6)

Both of these are non related to this PR so I am not sure what I can do to make it all pass.

NateWr commented 2 years ago

Travis has had a bunch of hiccups lately. I've restarted those again and I expect they'll pass. Let me know when you see they've finished.

asmecher commented 2 years ago

Thanks, all, I've gone ahead and merged these. There does seem to be a Cypress dependency issue lately on specific configurations only; if it doesn't resolve this week I'll contact Travis about it.