Closed bozana closed 1 year ago
@asmecher, should the DC meta elements be displayed on the galley i.e. file view page in OJS, as this is the case in OMP? Or should the OMP be change so that the DC elements are only displayed on the book/chapter view page (as this is the case for GoogleScholarPlugin)? Currently, in OMP, the only difference between the DC elements on the submission and representation/file view page are the elements DC.Identifier and DC.Identifier.URI. If we would like to keep the DC elements on both pages (submission and representation), then eventually also DC.Format , DC.Identifier.DOI, DC.Language and DC.Type could be changed to only display values of that particular representation? Something else? :thinking:
EDIT: And one more question: what is 'sponsor' here https://github.com/pkp/ojs/blob/main/plugins/generic/dublinCoreMeta/DublinCoreMetaPlugin.php#L79? 'Supporting Agencies' i.e. 'submissionAgency' in DB table controlled_vocabs?
This Issue changes/improves the following: OJS and OMP:
$i
to differentiate template headers use $locale
if already there, or use $i
from already existing foreach
loops.additionally in OMP:
The way the subjects and keywords are get is also changed in GoogleScholar plugin
Hi @asmecher, For the representation i.e. submission file view pages I left everything as it was. This I can approach later, if needed. Else s. https://github.com/pkp/pkp-lib/issues/8406#issuecomment-1419244982 for the changes I have made now. Could you please review the PRs above?
Hi @asmecher, thanks a lot for the review! I considered everything (s. the last commits). Additionally: In OMP I also considered chapter for datePublished and pages, and I changed the way we assure the DC meta elements are displayed only for the current version when viewing a file (see the comment there). In OJS now I get the section from the TemplateManger. OK so?
Yes, I can't think of any problem with those approaches. Please go ahead, thanks!
There are a few things that should be considered in the DublinCoreMetaPlugin:
<meta name="DC.Description" xml:lang="fr" content=""/>
Adapt the DublinCoreMetaPlugin so that it does not consider/display empty content. I am not sure where the empty content in the DB comes from, because when using the UI forms they are not saved if empty.