search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
306 stars 445 forks source link

Controlled vocabularies are being URL decoded at input time #8511

Closed jonasraoni closed 1 year ago

jonasraoni commented 1 year ago

Describe the bug When inserting a controlled vocabulary item, the data is being URL decoded, which ends up changing the user input.

To Reproduce

  1. Access a submission
  2. Add a keyword with a text which is sensible for the urldecode() function, for example +test
  3. Check the saved data and see the plus is gone.

What application are you using? /stable-3_3_0 /main

PRs stable-3_3_0

main

jonasraoni commented 1 year ago

@asmecher Just to confirm, the urldecode() is just a fragment from the past, right? Or is there any special reason for it to be here?

PRs stable-3_3_0

main

asmecher commented 1 year ago

I believe it's due to the old UI tool we used to use for tags double-escaping things. I'm OK to remove it if it tests out to work well.

jonasraoni commented 1 year ago

It worked fine on my environment and the tests passed, so I've merged the PRs.