search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
306 stars 445 forks source link

Request payment step is missing when skipping external review if APC is enabled #8605

Closed Vitaliy-1 closed 1 year ago

Vitaliy-1 commented 1 year ago

Describe the bug When authors fees are enabled there should be an option to request payment when submission is accepted, either with or without the review.

When article is accepted after the review, request payment option is shown to the editor requestPayment But this doesn't happen when article is accepted after skipping the review acceptAndSkip

To Reproduce Steps to reproduce the behavior:

  1. Enable APC, as per docs
  2. Submit an article
  3. Make a decision to accept and skip review
  4. See the absence of the request payment option

What application are you using? OJS main branch

Additional information Looking at the backend part, RequestPayment trait is used in both, Accept and SkipExternalReview but the latter lacks getStep() method to initialise the payment form

Vitaliy-1 commented 1 year ago

PR OJS: https://github.com/pkp/ojs/pull/3744

Vitaliy-1 commented 1 year ago

@NateWr, it looks like an easy fix but can you take a look just in case, I'm not yet familiar with this part of code.

NateWr commented 1 year ago

Merged to main, thanks @Vitaliy-1!