search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
306 stars 445 forks source link

Display Error in "To:" Field of Email Composer #8748

Open emmauhl opened 1 year ago

emmauhl commented 1 year ago

Describe the bug The alignment of the user name and the "To:" field overlap.

To Reproduce Steps to reproduce the behavior:

  1. As a Journal Manager, send a submission to review.
  2. Opt to Notify Authors.
  3. The display error appears in the email composer.

image

I encountered this in the Journal Manager role at the stage where Authors are notified that their submission will be sent for review, in the Chrome browser. I didn't see this anywhere else in my testing but it's possible it might occur in other similar screens. It's pretty minor but I thought I should still share.

What application are you using? OJS 3.4 rc1

Additional information Please add any screenshots, logs or other information we can use to investigate this bug report.

NateWr commented 1 year ago

Thanks @emmauhl, does this happen every time you view the form? Or only sometimes? I will check it out in Chrome, but I suspect it is a race condition, meaning that it won't always happen and may be hard to replicate in different environments.

For example, the "Subject" field works exactly the same, but seems to be working in your screenshot.

emmauhl commented 1 year ago

I figured it could be a browser issue for sure. I saw this screen three times and it manifested in the same way each time, for what it's worth!

librariam commented 1 year ago

I'm seeing the same issue as reported by Emma in my OMP 3.4rc1 tests on Chrome/PC

NateWr commented 1 year ago

I'm not able to reproduce this on Chromium/Linux (Version 111.0.5563.110 (Official Build) snap (64-bit)) or Chrome/Windows (Version 111.0.5563.111 (Official Build) (64-bit)). @emmauhl and @librariam are either of you on Mac?

librariam commented 1 year ago

@NateWr I'm on PC (Windows 10) / Chrome (Version 111.0.5563.146 (Official Build) (64-bit)). That being said, I've just retested in both OJS and OMP 3.4.0rc1 and I see that the display starts out misaligned, like in Emma's screenshot, and then moves into place a moment later. It didn't move previously. There was at least one Chrome update between now and then so maybe that's the culprit.

Vitaliy-1 commented 1 year ago

That being said, I've just retested in both OJS and OMP 3.4.0rc1 and I see that the display starts out misaligned, like in Emma's screenshot, and then moves into place a moment later

I think that's expected. Some styling for that element is calculated dynamically and added later during the page load/Vue lifecycle.

Keeping a note for myself that it's likely related to this method: https://github.com/pkp/ui-library/blob/5dc971197ebefe8a456d51756fd22f850b030adf/src/components/Form/fields/FieldBaseAutosuggest.vue#L366

asmecher commented 1 year ago

I'm open to fixing this in time for 3.4.0-0, but it's not a show-stopper, so I'm deferring it for the moment to 3.4.0-1.