search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
297 stars 442 forks source link

Submission incomplete filter using old matching criteria #8779

Closed ewhanson closed 1 year ago

ewhanson commented 1 year ago

Describe the bug The incomplete submission filter is retrieving any incomplete results. In the database, the submission status now uses strings to denote submission_progress e.g. "start" or "details." The isIncomplete filter is checking if the value of submission_progress is greater than zero:

https://github.com/pkp/pkp-lib/blob/f57afe846ec66cae416e14203ed3c1a37e6765b3/classes/submission/Collector.php#L321-L323

To Reproduce Steps to reproduce the behavior:

  1. Go to submissions page.
  2. Filter submissions by incomplete.
  3. See no results even when incomplete submissions are present.

What application are you using? OJS 3.4 RC 1

Additional information N/A

asmecher commented 1 year ago

Fixed, thanks!