Closed jonasraoni closed 1 year ago
@asmecher Before I proceed...
The Section::getLocalizedPolicy()
does exist at OJS and OPS. So perhaps it makes sense to rename the field from 'descriptionto
policyand create a migration for OMP (then I'll just undo an update which removed the
getLocalizedPolicy()from the
PKPSection`).
The other solution would be to use a workaround (e.g. method_exists()
/check if it's OMP).
p.s.: It works in OMP 3.3, because the method getLocalizedPolicy()
used to be declared at the PKPSection
.
@jonasraoni, I'd be cautious about assuming the section description (OMP) and policy (OJS and OPS) serve the same purpose; can you double-check where the section policy is used in OMP?
I just found it here, so it's a description :) https://github.com/pkp/omp/blob/4a2e0b6fa92c755624b57b38466e2c38c60bea7a/templates/frontend/pages/catalogSeries.tpl#L35
Ok, so I'll just isolate the policy at the template level, which also needs to be fixed (it's listing disabled sections).
That sounds fine, thanks!
Merged, thanks! You could also use Smarty template inheritance in cases like this: https://www.smarty.net/inheritance
Yeah, this thought came to my mind (I remember Nate talked about it a long time ago), but then I saw another place using a similar construction, and ended up forgetting to research the syntax, whatever, now it's too late 😅
Describe the bug When acessing the About > Submissions a fatal error is generated, even though the page is displayed.
To Reproduce Steps to reproduce the behavior:
What application are you using? OMP 3.4.0rc1
PRs