Open jonasraoni opened 1 year ago
@asmecher Not sure if the tests will pass, but here are the initial PRs:
The issues which I've listed on the description are not addressed by these PRs, they will require further investigation, which I didn't start :)
Describe the bug The problems below were found while skimming through the code and are currently not covered by the linked PRs (which are fixing other random issues):
pkp-lib
The methods
getMetadataSchema()
andgetApplicationEntityIdFromMetadataDescription()
are not declared at the class:Given the
JWT::decode()
seems to return an object, it's curious to have it inside ajson_decode()
or being used as a string (there are similar cases at the application repository).OJS
Calls to non-existent methods
getSetting()
/updateSetting()
:⚠ Before updating the code to
setData()
/getData()
, it's probably needed to check if the field is part of the schema, otherwise it will be ignored.Another JWT::decode() vs string
The method
exportArticles()
doesn't exist: https://github.com/pkp/ojs/blob/9fa385a2b795985f3b745577a6400414c89016c4/plugins/importexport/pubmed/PubMedExportPlugin.php#L232OMP
Not sure if it's a bug, but the OMP doesn't have the "Distribution > Access" interface
The method
getInsertData()
isn't defined at the parent class https://github.com/pkp/omp/blob/2cfbb90c67d374016450bc40b07520dd5a090288/classes/statistics/TemporaryItemInvestigationsDAO.php#L31The method
getInsertData()
isn't defined at the parent class https://github.com/pkp/omp/blob/2cfbb90c67d374016450bc40b07520dd5a090288/classes/statistics/TemporaryItemRequestsDAO.php#L32The method
_getNotificationRequestOptions()
isn't defined at the parent class https://github.com/pkp/omp/blob/2cfbb90c67d374016450bc40b07520dd5a090288/pages/authorDashboard/AuthorDashboardHandler.php#L110The methods
$submission->setUserId()
and$submissionFile->setDateUploaded()
do not exist. https://github.com/pkp/omp/blob/690e2be1e0a879be57ca659f47acf51a3466a470/plugins/importexport/csv/CSVImportExportPlugin.php#L158 https://github.com/pkp/omp/blob/690e2be1e0a879be57ca659f47acf51a3466a470/plugins/importexport/csv/CSVImportExportPlugin.php#L247OPS
The
OPSPaymentManager
is missing.The
UserImportExportPlugin
is missing.tests\plugins\importexport\PubObjectCacheTest.php
has several issues.PRs