search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
297 stars 443 forks source link

Fix getPublishedSubmissions, getPublishedIssues and getArticleGalleys in DOIPubIdExportPlugin and PubObjectsExportPlugin #8956

Closed bozana closed 1 year ago

bozana commented 1 year ago

The functions getPublishedSubmissions and getArticleGalleys in DOIPubIdExportPlugin and PubObjectsExportPlugin do not consider context when getting the objects, which is above all important when the functions are called from CLI. The function getPublishedSubmissions in DOIPubIdExportPlugin does not consider if the DOI exist for a submission. Also, the collectors' filter function could be used now.

PRs:

bozana commented 1 year ago

@ewhanson, could you please take a look at the PRs above?

ewhanson commented 1 year ago

Hey @bozana, I've taken a look and it looks good! I just had a few naming/style comments. Other than that, it looks ready to go. Was there nothing in OMP that needed to be updated in the same way?

bozana commented 1 year ago

Hi @ewhanson, I considered the comments, and rebased. Once the tests pass I will merge... Thanks a lot!