search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
304 stars 444 forks source link

[OMP] Undefined array key on Dashboard > Catalog #9175

Open jonasraoni opened 1 year ago

jonasraoni commented 1 year ago

Describe the bug Old OMP installations may present the following error:

Warning:  Undefined array key 1 in /var/www/html/classes/components/listPanels/CatalogListPanel.php on line 83

It happens because the category_settings probably didn't have the sortOption setting before, and the code is assuming that it has always existed.

Solution Provide a default value when null/non-existent, a deeper fix through a migration might be applied as well (if the field is required).

What application are you using? OMP 3.4.1

asmecher commented 1 year ago

It's just a warning, the next line of code ensures a sensible fallback is used, and it's resolved by saving the catalog settings form, which will eventually happen naturally; I'm tempted to leave this a WONTFIX.