search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
304 stars 444 forks source link

Missing locale key site.upgradeAvailable.admin in OMP #9294

Closed NateWr closed 1 month ago

NateWr commented 1 year ago

Describe the bug The locale key, site.upgradeAvailable.admin, is not present in OMP. This leads to a missing message in the site administration area.

To Reproduce I'm not sure of the reproduction steps, but I the message is shown when VersionCheck::checkIfNewVersionExists() returns true.

  1. Login as admin
  2. Go to Administration area
  3. See error

What application are you using? OMP main branch running a stable-3_4_0 database.

Additional information upgrade-available

kaitlinnewson commented 2 months ago

This looks like a case of just needing to move the locale key to pkp-lib from OJS, but it's not easy to reproduce because show_upgrade_warning is not typically set in the OMP config file/template (see also https://github.com/pkp/pkp-lib/issues/8543).

kaitlinnewson commented 2 months ago

PRs for review @asmecher:

asmecher commented 2 months ago

@kaitlinnewson, unfortunately the locale key makes explicit reference to OJS, and would need to be generalized in order to be moved to the pkp-lib shared library.

kaitlinnewson commented 2 months ago

@kaitlinnewson, unfortunately the locale key makes explicit reference to OJS, and would need to be generalized in order to be moved to the pkp-lib shared library.

🤦‍♀️ Not sure how I missed that! I'll work on generalizing this key.

kaitlinnewson commented 1 month ago

@asmecher I've updated the list of PRs above, ready for another review. Since we are not actively translating the 3.3 branch, I've copied over the full text from OJS and updated the strings to OMP where possible.

For 3.4/main, I made a small change to the english text so we aren't using "here" links to follow better accessibility practices.

asmecher commented 1 month ago

Thanks, @kaitlinnewson, looks good! Were those stable-3_3_0 translations adapted manually from OJS translations, or machine translated, or something else? Generally speaking, it's good to mark them fuzzy so anyone working with translation tools can give them a review.

asmecher commented 1 month ago

:arrow_up: Sorry, I see you specified that these were adapted manually. Should be good to go!

asmecher commented 1 month ago

All merged, thanks!