search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
298 stars 443 forks source link

Primary colour can't be set from the theme menu #9790

Open Vitaliy-1 opened 4 months ago

Vitaliy-1 commented 4 months ago

Describe the bug In the Appearance -> Theme menu, when trying to set new theme primary colour, changes aren't being saved.

To Reproduce Steps to reproduce the behavior:

  1. Go to Appearance -> Theme menu
  2. Set new primary colour
  3. Click 'Save' button
  4. Refresh the page
  5. See that new colour hasn't been applied, old value is displayed instead

What application are you using? OJS main branch

Additional information This causes failure of tests for all the themes

Vitaliy-1 commented 4 months ago

Looks like an issue with vue3-color. The parameter here isn't a new value but rather InputEvent. @jardakotesovec, can you take a look?

jardakotesovec commented 4 months ago

@Vitaliy-1 Oki, good news its just 3.5. Will try to get to that soonish (next week), so its not blocking theme tests, ok?

Vitaliy-1 commented 4 months ago

It fails tests on Travis for the main. I haven't created 3.4 branch yet.

jardakotesovec commented 4 months ago

@Vitaliy-1 Just merged the fix (https://github.com/pkp/ui-library/pull/336). Feel free to close it once you can verify that the tests are working now.

Vitaliy-1 commented 4 months ago

I've re-run tests for Health Sciences