search

pkp / pkp-lib

The library used by PKP's applications OJS, OMP and OPS, open source software for scholarly publishing.
https://pkp.sfu.ca
GNU General Public License v3.0
297 stars 442 forks source link

Upgrade to Laravel version 11.x #9892

Closed touhidurabir closed 3 weeks ago

touhidurabir commented 4 months ago

Describe the Proposal With the intension to make the release of 3.5.0 a LTS, we should aim to have all the dependencies updated as much as possible . The current main(pre release of 3.5.0) now have Laravel 10.x as the dependency which will be get bug fix till August 6th, 2024 . Also by the time the 3.5.0 get to release it will be an older version of laravel . Better to upgrade the laravel version to 11.x .

Additional Information With the release of stable laravel version 11.x at March 12th, 2024 which seems like a more of better candidate for next LTS release as it will have a longer support period, more details at https://laravel.com/docs/11.x/releases#support-policy . The most important requirement for it is PHP 8.2+ which is also seems like a good opportunity to ship the next LTS with more actively supported PHP version as PHP 8.1 will be at the end of active support by next release, more details at https://www.php.net/supported-versions.php .

The upgrade process and details does not seems to contains many high impact changes and most of those seems to be resolvable with less effort, more details at https://laravel.com/docs/11.x/upgrade .

PRs pkp-lib --> https://github.com/pkp/pkp-lib/pull/10211 ojs --> https://github.com/pkp/ojs/pull/4367 omp --> https://github.com/pkp/omp/pull/1669 ops --> https://github.com/pkp/ops/pull/748

asmecher commented 4 months ago

@touhidurabir, I checked with the Technical Committee, and they didn't raise any problems with bumping our PHP base to 8.2 for OJS/OMP/OPS 3.5. They're primarily familiar with RHEL (EPEL) and Debian/Ubuntu.

touhidurabir commented 1 month ago

@asmecher can you review it at https://github.com/pkp/pkp-lib/issues/9892#issue-2248712326 . Unit tests are still failing as we need to update the github workflow main branch to make it phpunit test command compatible with version 11 .

asmecher commented 1 month ago

@touhidurabir, I think you're probably referring to this change, which got merged last week; did it resolve the problem?

asmecher commented 1 month ago

I've added reviews to ojs and pkp-lib, thanks, @touhidurabir!

touhidurabir commented 1 month ago

@touhidurabir, I think you're probably referring to this change, which got merged last week; did it resolve the problem?

@asmecher that was one part but I missed another one where set flag -v not supported by PHPUnit 11 anymore . I will create a new PR soon for this .

touhidurabir commented 4 weeks ago

@asmecher tests are finally passing . Can you please take a second look , PRs at https://github.com/pkp/pkp-lib/issues/9892#issue-2248712326

asmecher commented 4 weeks ago

Thanks, @touhidurabir, I've added a review to the pkp-lib PR. There are a couple small things to look at, but once you're satisfied, please port to OMP and OPS and let's get it merged! I appreciate the attention to detail here.

touhidurabir commented 3 weeks ago

@asmecher All tests are passing and resolved all pointed reviews at https://github.com/pkp/pkp-lib/pull/10211#pullrequestreview-2228783482 . Just one query to review at https://github.com/pkp/omp/pull/1669#discussion_r1713384194 . If all ok, should be good to merge .

asmecher commented 3 weeks ago

All merged -- thanks, @touhidurabir!

touhidurabir commented 3 weeks ago

@asmecher do you think anything more required for this ? may be some plugins ?

asmecher commented 3 weeks ago

Nothing off the top of my head -- but I'll keep an eye out. Closing, thanks!