jim13731
commented
2 weeks ago @Vitaliy-1 Thank you for the sharing the files path.
I have added functionality to log email data for the "Add Reviewer" action in OJS 3.4. Below are the changes made:
Files Modified lib/pkp/classes/log/event/PKPSubmissionEventLogEntry.php lib/pkp/classes/submission/action/EditorAction.php
Changes
- lib/pkp/classes/log/event/PKPSubmissionEventLogEntry.php
Added new constants for email events:
`class PKPSubmissionEventLogEntry extends EventLogEntry { // ... existing constants ...
public const SUBMISSION_EMAIL_REVIEW_REQUEST = 0x50000001;
public const SUBMISSION_EMAIL_REVIEW_REQUEST_SUBSEQUENT = 0x50000002;
// ... existing methods ...} `
- lib/pkp/classes/submission/action/EditorAction.php
Modified the addReviewer method to include email logging:
`public function addReviewer($request, $submission, $reviewerId, &$reviewRound, $reviewDueDate, $responseDueDate, $reviewMethod = null) { // ... existing code ...
if (!$assigned && isset($reviewer) && !Hook::call('EditorAction::addReviewer', [&$submission, $reviewerId])) {
// ... existing code ...
// Send mail
if (!$request->getUserVar('skipEmail')) {
$context = PKPServices::get('context')->get($submission->getData('contextId'));
$emailTemplate = Repo::emailTemplate()->getByKey($submission->getData('contextId'), $request->getUserVar('template'));
$emailBody = $request->getUserVar('personalMessage');
$emailSubject = $emailTemplate->getLocalizedData('subject');
$mailable = $this->createMail($submission, $reviewAssignment, $reviewer, $user, $emailBody, $emailSubject, $context);
try {
Mail::send($mailable);
// Log email
$eventType = ($reviewRound->getRound() == 1) ? PKPSubmissionEventLogEntry::SUBMISSION_EMAIL_REVIEW_REQUEST : PKPSubmissionEventLogEntry::SUBMISSION_EMAIL_REVIEW_REQUEST_SUBSEQUENT;
$submissionEmailLogDao = DAORegistry::getDAO('SubmissionEmailLogDAO');
$submissionEmailLogDao->logMailable($eventType, $mailable, $submission, $user);
} catch (TransportException $e) {
$notificationMgr = new PKPNotificationManager();
$notificationMgr->createTrivialNotification(
$user->getId(),
PKPNotification::NOTIFICATION_TYPE_ERROR,
['contents' => __('email.compose.error')]
);
trigger_error('Failed to send email: ' . $e->getMessage(), E_USER_WARNING);
}
}
}}
Summary
These changes ensure that email data is logged whenever a reviewer is added.`
taslangraham
Describe the bug Described on the forum https://forum.pkp.sfu.ca/t/review-request-emails-no-longer-logged-in-ojs-3-4-intentionally/88499
In 3.3, when sending a review request email, the email information was recorded in the
email_logtable. It didn't have a specificevent_typefor that action.To Reproduce Steps to reproduce the behavior:
Add Revieweremail_logtableWhat application are you using? OJS 3.4, OJS main
Additional information
SUBMISSION_EMAIL_REVIEW_REQUESTandSUBMISSION_EMAIL_REVIEW_REQUEST_SUBSEQUENTPKP\submission\action\EditorAction::addReviewer(), usePKP\log\SubmissionEmailLogDAO::logMailable()to record the data.