search

pkp / plagiarism

Plagiarism checker plugin for OJS 3/OMP
GNU General Public License v3.0
7 stars 32 forks source link

sendErrorMessage use wrong field to create notification #58

Closed phulamnguyen closed 3 months ago

phulamnguyen commented 6 months ago

function createTrivialNotification($userId, ...) { .. } has the first params is $userId. But in the function sendErrorMessage, it uses table userGroup and passes group id to the param userId of function createTrivialNotification. So when sendErrorMessage is called, it makes an error insert notification because of foreign key constraints. Please fix it soon.

touhidurabir commented 6 months ago

@phulamnguyen which version of plugin are you using ? and also for which version of OJS/OMP ? I can see that in the current latest release at https://github.com/pkp/plagiarism/releases , it has been fixed .

phulamnguyen commented 6 months ago

my ojs version is 3.4.0.5, the first installed version is 3.4, I just upgraded to version 3.4.0.5 a few days ago, and I see the structure of table notification is using user_id instead of user group id.

touhidurabir commented 6 months ago

We haven't released any version for 3.4.0+ yet . I understand where the problem is arising . Currently we are working to update the ithenticate api (see pkp/plagiarism#52) to the latest version and once that is done, we will release for 3.4.0+ . in the mean time if you need to use it with 3.4.0+, you need to checkout from the latest main branch to make it work.

touhidurabir commented 3 months ago

Not planned yet . see https://github.com/pkp/plagiarism/issues/58#issuecomment-1975795049